From e196541f2a0544569709b046877e946add3a3ccd Mon Sep 17 00:00:00 2001
From: Leyla Becker <git@jan-leila.com>
Date: Sun, 16 Nov 2025 00:12:29 -0600
Subject: [PATCH] feat: filter out impermanence datasets that dont do anything

---
 modules/nixos-modules/storage/impermanence.nix | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/modules/nixos-modules/storage/impermanence.nix b/modules/nixos-modules/storage/impermanence.nix
index db0deb0..8f6d6d8 100644
--- a/modules/nixos-modules/storage/impermanence.nix
+++ b/modules/nixos-modules/storage/impermanence.nix
@@ -109,7 +109,14 @@ in {
             };
           }) (lib.filterAttrs (_: fileConfig: fileConfig.enable) dataset.files);
         })
-        config.storage.impermanence.datasets;
+        (lib.filterAttrs (
+            datasetName: dataset: let
+              enabledDirectories = lib.filterAttrs (_: dirConfig: dirConfig.enable) dataset.directories;
+              enabledFiles = lib.filterAttrs (_: fileConfig: fileConfig.enable) dataset.files;
+            in
+              (enabledDirectories != {}) || (enabledFiles != {})
+          )
+          config.storage.impermanence.datasets);
     }
     (lib.mkIf config.storage.zfs.enable {
       storage.zfs.datasets =